Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boundary visualization for 2.5.2 #9062

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Fix boundary visualization for 2.5.2 #9062

merged 3 commits into from
Dec 17, 2020

Conversation

keveleigh
Copy link
Contributor

Overview

In testing #9060, I realized that the boundary floor never shows up. In debugging, I realized we had a PR for 2.5.0 that moved the profile read before the bounds calculation, which means the visualization is never triggered. This is a regression from 2.4, so we're choosing to take this change in 2.5.2.

This change

  1. Refactors out some common code from the property setters, so we only have to make changes to the flow in one place (and allows us to refresh the visualization without raising events)
  2. Gates the event behind initialization, so we don't send a stream of them during profile read
  3. Refreshes the visualization near the end of initialization

@keveleigh keveleigh added this to the MRTK 2.5.2 milestone Dec 17, 2020
@keveleigh keveleigh self-assigned this Dec 17, 2020
@keveleigh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

david-c-kline
david-c-kline approved these changes Dec 17, 2020
View reviewed changes
Copy link

@david-c-kline david-c-kline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@keveleigh keveleigh merged commit 260fd66 into microsoft:releases/2.5.2 Dec 17, 2020
@keveleigh keveleigh deleted the boundary-2.5.2 branch December 17, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-c-kline david-c-kline david-c-kline approved these changes

Assignees

@keveleigh keveleigh

Labels
Boundaries
Projects
None yet
Milestone
MRTK 2.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@keveleigh @david-c-kline