handle case of no MotionControllerVisualizer singleton #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-c-kline
added
Bug
Platform - HoloLens - First Gen
keveleigh
reviewed
May 10, 2018
| } | ||
|
|
||
| /// <summary> | ||
| /// Base Awake method that sets the Singleton's unique instance. |
There was a problem hiding this comment.
that IS weird.... i'll make sure I have the right tabs/spaces setting
There was a problem hiding this comment.
git it not telling me anything changed after i forced new tabbing... MIGHT just be a diff view issue
There was a problem hiding this comment.
found it.... the issue was in a pre-existing comment it seems
StephenHodgson
approved these changes
May 10, 2018
| /// <returns>The value of the Singleton's IsInitialized property</returns> | ||
| public static bool ConfirmInitialized() | ||
| { | ||
| T access = Instance; |
There was a problem hiding this comment.
This wasn't in the master branch already?
Any other singleton changes we didn't have?
There was a problem hiding this comment.
it wasn't. i will look and open a PR if i see any more missing code
There was a problem hiding this comment.
I thought the same thing!
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Eliminates NullReferenceException when using the Solver System if the MotionControllers prefab is not in the scene (typically attached to the camera)
Changes
Adds ConfirmInitialized() to Singleton (back-port from Dev_Working_Branch)
Checks that the MotionControllerVisualizer has been initialized in ControllerFinder.OnEnable()
Fixes: NullReferenceException in ControllerFinder.OnEnable when using the HoloLensCamera #2053.