-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NullReferenceException in ControllerFinder.OnEnable when using the HoloLensCamera #2053
Comments
The HoloLens camera prefab is depreciated. Probably best to remove. |
While I agree that the HoloLens camera should probably be removed, we should still harden the controller finder, in case someone removes the controller from the MixedRealityCamera prefab (ex: HoloLens only projects) |
People shouldn't be removing things from prefabs anyway. |
Using the MixedRealityCamera prefab will also cause this issue (though it might be good to deprecate that as well and narrow down to one configurable camera prefab instead). |
@StephenHodgson, it could be argued that if people are removing things (that they don't need or that their target platform does not support) from prefabs the prefabs have too much on them by default. |
Yup, that's why we're taking the configuration profile approach in vNEXT. |
dev branch version of the fix for #2053
This was released in the 2017.4.0.0 release candidate |
This occurs due to there not being a motion controller attached to the camera.
The fix is to check whether or not the motion controller singleton has initialized rather than assuming it is safe to use the instance.
Mixed Reality Toolkit Release Version
2017.2.1.4
The text was updated successfully, but these errors were encountered: