Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullReferenceException in ControllerFinder.OnEnable when using the HoloLensCamera #2053

Closed
david-c-kline opened this issue May 7, 2018 · 7 comments
Assignees
Labels
Platform - HoloLens - First Gen Issues specific to Microsoft HoloLens

Comments

@david-c-kline
Copy link

This occurs due to there not being a motion controller attached to the camera.

The fix is to check whether or not the motion controller singleton has initialized rather than assuming it is safe to use the instance.

Mixed Reality Toolkit Release Version

2017.2.1.4

@david-c-kline david-c-kline added Bug Platform - HoloLens - First Gen Issues specific to Microsoft HoloLens labels May 7, 2018
@david-c-kline david-c-kline self-assigned this May 7, 2018
@StephenHodgson
Copy link
Contributor

The HoloLens camera prefab is depreciated.

Probably best to remove.

@david-c-kline
Copy link
Author

@StephenHodgson,

While I agree that the HoloLens camera should probably be removed, we should still harden the controller finder, in case someone removes the controller from the MixedRealityCamera prefab (ex: HoloLens only projects)

@StephenHodgson
Copy link
Contributor

People shouldn't be removing things from prefabs anyway.

@keveleigh
Copy link
Contributor

keveleigh commented May 8, 2018

Using the MixedRealityCamera prefab will also cause this issue (though it might be good to deprecate that as well and narrow down to one configurable camera prefab instead).

@david-c-kline
Copy link
Author

@StephenHodgson, it could be argued that if people are removing things (that they don't need or that their target platform does not support) from prefabs the prefabs have too much on them by default.

@StephenHodgson
Copy link
Contributor

Yup, that's why we're taking the configuration profile approach in vNEXT.

@david-c-kline
Copy link
Author

This was released in the 2017.4.0.0 release candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform - HoloLens - First Gen Issues specific to Microsoft HoloLens
Projects
None yet
Development

No branches or pull requests

3 participants