Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New unit test to check for wrongfully assigned ReadWrite-permissions. #4320

Closed
wants to merge 68 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
d8e620a
Fix nested change detection in CIMInstance
Jan 5, 2024
71295a4
Fix enrollment platform restriction comparison during report creation
Jan 5, 2024
aeb7187
Merge branch 'Dev' into fix-dsc-report
NikCharlebois Jan 17, 2024
85b7d64
Merge branch 'Dev' into fix-dsc-report
Jan 19, 2024
3a5c1f3
Merge branch 'Dev' into fix-dsc-report
Jan 25, 2024
af83884
Merge branch 'Dev' into fix-dsc-report
Jan 26, 2024
e6b41e7
Adds a unittest for read permissions + fixes
andikrueger Jan 30, 2024
342d577
First commit DLPCompliance params
tayhall Feb 5, 2024
6e990a4
Merge branch 'Dev' into fix-dsc-report
NikCharlebois Feb 5, 2024
ed4e62c
added setheader and none for blockaccessscope
tayhall Feb 6, 2024
f82ee38
removed quote
tayhall Feb 6, 2024
f5fa6f4
Fix nested array resource comparison
FabienTschanz Feb 6, 2024
7df5c81
Fixed tests so that resource reports its correct state
ricmestre Feb 8, 2024
0b62229
Fix Test-TargetResource to ensure that resource reports its correct s…
ricmestre Feb 8, 2024
0996819
Use correct filter
ricmestre Feb 8, 2024
c60ced4
Remove Id from being tested and auth methods
ricmestre Feb 8, 2024
c33229e
Update CHANGELOG.md
ricmestre Feb 8, 2024
7f22867
Fix typo
ricmestre Feb 8, 2024
9de19f1
Backticks not required here
ricmestre Feb 8, 2024
47e6bb3
Remove auth methods from testing
ricmestre Feb 8, 2024
050f282
Export, and test, correct variable
ricmestre Feb 8, 2024
eadc0a2
Update CHANGELOG.md
ricmestre Feb 8, 2024
bb3ba4b
Merge branch 'Dev' into fix3964
ricmestre Feb 9, 2024
2fd5fba
Merge branch 'Dev' into fix3542
ricmestre Feb 9, 2024
ceeeedb
Merge branch 'Dev' into fix3959
ricmestre Feb 9, 2024
a5c30ae
Merge branch 'Dev' into fix3972
ricmestre Feb 9, 2024
0e3c4c2
Merge branch 'Dev' into fix3542
ricmestre Feb 9, 2024
1b00616
Merge branch 'Dev' into fix3959
ricmestre Feb 9, 2024
06f96bc
Merge branch 'Dev' into fix3964
ricmestre Feb 9, 2024
5aafced
Merge branch 'Dev' into fix3972
ricmestre Feb 9, 2024
775fd09
Merge branch 'Dev' into fix3542
ricmestre Feb 9, 2024
341451a
Merge branch 'Dev' into fix3959
ricmestre Feb 9, 2024
a9726fa
Merge branch 'Dev' into fix3964
ricmestre Feb 9, 2024
2bdea00
Merge branch 'Dev' into fix3972
ricmestre Feb 9, 2024
adcd1c6
Merge branch 'Dev' into fix3542
ricmestre Feb 12, 2024
e3a699a
Merge branch 'Dev' into fix3959
ricmestre Feb 12, 2024
6ff8eec
Merge branch 'Dev' into fix3964
ricmestre Feb 12, 2024
d698de7
Merge branch 'Dev' into fix3972
ricmestre Feb 12, 2024
cf116c5
Updated DSCParser
NikCharlebois Feb 14, 2024
be4aab3
Adds a unittest for read permissions + fixes
andikrueger Jan 30, 2024
d7f225d
Merge branch 'UnitTestReadPermissions' of https://github.com/andikrue…
andikrueger Feb 14, 2024
a475661
add test to SettingJson.Test file
andikrueger Feb 14, 2024
cff51f9
Merge pull request #4319 from NikCharlebois/DSCParser
NikCharlebois Feb 14, 2024
95777b8
Merge pull request #4307 from ricmestre/fix3972
NikCharlebois Feb 14, 2024
1e43002
Merge branch 'Dev' into fix3964
NikCharlebois Feb 14, 2024
c7ae8c7
Merge pull request #4306 from ricmestre/fix3964
NikCharlebois Feb 14, 2024
f506a70
Merge branch 'Dev' into fix-dsc-report
NikCharlebois Feb 14, 2024
9d039e4
Merge pull request #4126 from FabienTschanz/fix-dsc-report
NikCharlebois Feb 14, 2024
e5c1a1b
Merge branch 'Dev' into fix3959
NikCharlebois Feb 14, 2024
53fc015
Merge pull request #4305 from ricmestre/fix3959
NikCharlebois Feb 14, 2024
7ae5091
Merge branch 'Dev' into fix3542
NikCharlebois Feb 14, 2024
df00ffe
changed Policy.Read.AuthenticationMethod back to ReadWrite
andikrueger Feb 14, 2024
e9c39c7
Merge pull request #4304 from ricmestre/fix3542
NikCharlebois Feb 14, 2024
4f6637e
Updated Resources and Cmdlet documentation pages
NikCharlebois Feb 14, 2024
2bf2b89
Rollback of Teams Permission changes.
andikrueger Feb 14, 2024
561af45
Merge branch 'Dev' into DLPRules
NikCharlebois Feb 14, 2024
237868b
Merge pull request #4288 from tayhall/DLPRules
NikCharlebois Feb 14, 2024
6db4774
Updated Resources and Cmdlet documentation pages
NikCharlebois Feb 14, 2024
8b958eb
New pester config
andikrueger Feb 14, 2024
f4ed6fa
Updated Teams settings.json and unit test
andikrueger Feb 14, 2024
3553068
Adds a unittest for read permissions + fixes
andikrueger Jan 30, 2024
904592a
add test to SettingJson.Test file
andikrueger Feb 14, 2024
9fe103d
changed Policy.Read.AuthenticationMethod back to ReadWrite
andikrueger Feb 14, 2024
8732879
Rollback of Teams Permission changes.
andikrueger Feb 14, 2024
3353eda
New pester config
andikrueger Feb 14, 2024
e60c34a
Updated Teams settings.json and unit test
andikrueger Feb 14, 2024
6cc3050
Merge branch 'UnitTestReadPermissions' of https://github.com/andikrue…
andikrueger Feb 14, 2024
7fcc27b
Added changelog entry
andikrueger Feb 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,34 @@
* EXOMobileDeviceMailboxPolicy
* Fixes an issue where an empty MinPasswordLength value was always passed down
to the update logic flow.
* IntuneAppConfigurationPolicy
* Added parameter Id to avoid having to retrieve the same policy multiple
times
* Fixed tests in Test-TargetResource to ensure the resource reports its
correct state
FIXES [#3542](https://github.com/microsoft/Microsoft365DSC/issues/3542)
* IntuneDeviceAndAppManagementAssignmentFilter
* Fixed Test-TargetResource to ensure that resource reports its correct state
FIXES [#3959](https://github.com/microsoft/Microsoft365DSC/issues/3959)
* IntuneDeviceConfigurationNetworkBoundaryPolicyWindows10
* Fixed Test-TargetResource by removing Id from being tested and also used
correct filter while retrieving the policy otherwise it could not be found
FIXES [#3964](https://github.com/microsoft/Microsoft365DSC/issues/3964)
* IntuneDeviceConfigurationPolicyAndroidWorkProfile
* Fix typo in variable which made it export incorrectly and report that
resource was not in correct state due to testing an incorrect value
FIXES [#3972](https://github.com/microsoft/Microsoft365DSC/issues/3972)
* Teams resources
* Updated required application permissions to support [Application Based Authentication](https://learn.microsoft.com/en-us/microsoftteams/teams-powershell-application-authentication)
* DEPENDENCIES
* Updated DSCParser to version 1.4.0.2.
* Updated Microsoft.Graph dependencies to version 2.13.1.
* Updated MSCloudLoginAssistant to version 1.1.13.
* MISC
* M365DSCReport
* Fix nested change detection for CIMInstances
* Fix IntuneDeviceEnrolllmentPlatformRestriction comparison in report
FIXES [#4291](https://github.com/microsoft/Microsoft365DSC/issues/4291)

# 1.24.207.2

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
"read": [
{
"name": "EntitlementManagement.Read.All"
},
{
"name": "EntitlementManagement.ReadWrite.All"
}
],
"update": [
Expand All @@ -33,9 +30,6 @@
"read": [
{
"name": "EntitlementManagement.Read.All"
},
{
"name": "EntitlementManagement.ReadWrite.All"
}
],
"update": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"application": {
"read": [
{
"name": "RoleEligibilitySchedule.ReadWrite.Directory"
"name": "RoleEligibilitySchedule.Read.Directory"
}
],
"update": [
Expand Down
Loading
Loading