New unit test to check for wrongfully assigned ReadWrite-permissions. #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated DSCParser
IntuneDeviceConfigurationPolicyAndroidWorkProfile: Fix typo that makes it export incorrectly and not reporting the correct state of resource
IntuneDeviceConfigurationNetworkBoundaryPolicyWindows10: Fix Test-TargetResource and use correct filter to retrieve policy
Fix nested change detection in CIMInstance and resource comparison
IntuneDeviceAndAppManagementAssignmentFilter: Fix Test-TargetResource to ensure that resource reports its correct state
IntuneAppConfigurationPolicy: Fixed tests so that resource reports its correct state
DLPCompliance Rules additional parameters
|
Just to add some more context to this PR Right now, there a few resources that would request write Permission even though only an export of the tenant is needed. This PR tries to add a quality gate to the settings.json files to only allow read permission for Microsoft graph in the “read” case. |
…ger/Microsoft365DSC into UnitTestReadPermissions
|
Will create a new PR as the last rebase messed this one up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
New unit test to check for wrongfully assigned ReadWrite-permissions.