Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert-m365DscHashtableToString formatting - fixes #2980 #3059

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
FIXES [#3050](https://github.com/microsoft/Microsoft365DSC/issues/3050)
* MISC
* Added QA test that checks for existence of an example for each resource.
* Amended output for Convert-M365DscHashtableToString to show each value on a new line
Fixes[#2980](https://github.com/microsoft/Microsoft365DSC/issues/2980)
* DRG
* Various fixes:
Remove invalid character from description in schema.mof
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1008,8 +1008,8 @@ function Test-TargetResource
# remove thre ID from the values to check as it may not match
$targetvalues.remove('ID') | Out-Null

Write-Verbose -Message "Current Values: $((Convert-M365DscHashtableToString -Hashtable $CurrentValues) -replace ';', "`r`n")"
Write-Verbose -Message "Target Values: $((Convert-M365DscHashtableToString -Hashtable $targetvalues) -replace ';', "`r`n")"
Write-Verbose -Message "Current Values: $(Convert-M365DscHashtableToString -Hashtable $CurrentValues)"
Write-Verbose -Message "Target Values: $(Convert-M365DscHashtableToString -Hashtable $targetvalues)"

$TestResult = Test-M365DSCParameterState -CurrentValues $CurrentValues `
-Source $($MyInvocation.MyCommand.Source) `
Expand Down
2 changes: 1 addition & 1 deletion Modules/Microsoft365DSC/Modules/M365DSCUtil.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ function Convert-M365DscHashtableToString
}

[array]::Sort($values)
return ($values -join '; ')
return ($values -join "`r`n")
}

<#
Expand Down