Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert-m365DscHashtableToString formatting - fixes #2980 #3059

Conversation

menswearUK
Copy link
Contributor

Pull Request (PR) description

Proposed fix for #2980. The fix itself is purely an amendment to the output string for the function to use a carriage return and newline instead of a semicolon as the separator.

This would apply to all configurations which use the function (which is most of them) I don't think there are any using it for anything other than verbose output but, if we wished to be more cautious, I could keep the default output and add in a switch for the newline output. If I did that any uses of the function would need to manually changed to use the switch.

The only other change is an amendment to IntuneAppProtectionPolicyAndroid which was already amending these values after the function had returned the string.

This Pull Request (PR) fixes the following issues

Fixes #2980

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 11a74ef into microsoft:Dev Mar 22, 2023
@menswearUK menswearUK deleted the Convert-M365DscHashtableToString-formatting-#2980 branch March 27, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function Convert-M365DscHashtableToString - Enhance formatting
2 participants