Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes quotes around vars for auths - fixes #2784 #2785

Merged
merged 6 commits into from
Jan 17, 2023
Merged

Removes quotes around vars for auths - fixes #2784 #2785

merged 6 commits into from
Jan 17, 2023

Conversation

bjoernf73
Copy link
Contributor

Pull Request (PR) description

Removes quotes around vars for auths, see #2784

This Pull Request (PR) fixes the following issues

Copy link
Collaborator

@andikrueger andikrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the comments and add a note to the changelog. Thanks!

@bjoernf73 bjoernf73 requested review from andikrueger and removed request for NikCharlebois January 16, 2023 16:27
@bjoernf73
Copy link
Contributor Author

@andikrueger Should be resolved now.

Copy link
Collaborator

@andikrueger andikrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit ebbf044 into microsoft:Dev Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlannerTask: Quotes not removed around ApplicationId, CertificateThumbprint, TenantId etc
3 participants