PlannerTask: Quotes not removed around ApplicationId, CertificateThumbprint, TenantId etc

[bjoernf73]

Details of the scenario you tried and the problem that is occurring

Previously, only Credential auth was supported for Planner, therefore, in MSFT_PlannerTask.psm1, function Export-TargetResource, line 787:

$content = Convert-DSCStringParamToVariable -DSCBlock $content `
    -ParameterName 'Credential'

ensures that quotes are removed around $ConfigurationData.NonNodeData.Credential:

PlannerTask 7ad38863-ce48-4b8e-b169-c292222471e6
{
    Bucket = "nYij0yLaMJ-KKPkQnX1wGpcAMF4C";
    Categories = @("Blue");
    Credential = $ConfigurationData.NonNodeData.Credential;
    DueDateTime = "15.05.2019 10:00:00";
    Ensure = "Present";
    PercentComplete = 100;
    PlanId = "j0P6vPeqpUiI2UUlwClBjZcAHXJ4";
    Priority = 5;
    TaskId = "SC81Z9zF9EGMlI76hYauj5cAD8o4";
    Title = "Some Title";
}

However, if for instance if Certificate is used for auth, quotes are not removed for properties related to that (i.e. CertificateThumbPrint, ApplicationId, TenantId):

PlannerTask 7ad38863-ce48-4b8e-b169-c292222471e6
{
    # ApplicationId will fail because of the quotes below
    ApplicationId = "$ConfigurationData.NonNodeData.ApplicationId";
    Bucket = "nYij0yLaMJ-KKPkQnX1wGpcAMF4C";
    Categories = @("Blue");
    # CertificateThumbprint will fail because of the quotes below
    CertificateThumbprint = "$ConfigurationData.NonNodeData.CertificateThumbprint";
    DueDateTime = "15.05.2019 10:00:00";
    Ensure = "Present";
    PercentComplete = 100;
    PlanId = "j0P6vPeqpUiI2UUlwClBjXcAHXJ4";
    Priority = 5;
    TaskId = "SC91Z8zF9EGMlI76hYauj5cAD8o4";
    # TenantId will fail because of the quotes below
    TenantId = "$ConfigurationData.NonNodeData.TenantId";
    Title = "Some task";
}

Verbose logs showing the problem

n/a

Suggested solution to the issue

Change the following in MSFT_PlannetTask.psm1, function Export-TargetResource, starting at line 787:

$content = Convert-DSCStringParamToVariable -DSCBlock $content `
    -ParameterName 'Credential'

with the following lines:

# Ensure quotes are removed around auth variables
if ($Credential) 
{
    $content = Convert-DSCStringParamToVariable -DSCBlock $content `
        -ParameterName 'Credential'
}
if ($ApplicationId) 
{
    $content = Convert-DSCStringParamToVariable -DSCBlock $content `
        -ParameterName 'ApplicationId'
}
if ($ApplicationSecret) 
{
    $content = Convert-DSCStringParamToVariable -DSCBlock $content `
        -ParameterName 'ApplicationSecret'
}
if ($TenantId) 
{
    $content = Convert-DSCStringParamToVariable -DSCBlock $content `
        -ParameterName 'TenantId'
}
if ($CertificateThumbprint) 
{
    $content = Convert-DSCStringParamToVariable -DSCBlock $content `
        -ParameterName 'CertificateThumbprint'
}

The DSC configuration that is used to reproduce the issue (as detailed as possible)

just exporting

The operating system the target node is running

OsName : Microsoft Windows 10 Enterprise
OsOperatingSystemSKU : EnterpriseEdition
OsArchitecture : 64-bit
WindowsVersion : 2009
WindowsBuildLabEx : 19041.1.amd64fre.vb_release.191206-1406
OsLanguage : en-US
OsMuiLanguages : {en-US, nb-NO}

Version of the DSC module that was used ('dev' if using current dev branch)

Dev