Bug 1374419: Address static analysis requirements for MIEngine

eng/pipelines/DebuggerTesting-release.yml

@@ -6,7 +6,7 @@ variables:
 - name: TeamName
   value: MDDDebugger
 jobs:
-- template: ./jobs/VSEngSS-MicroBuild2019-1ES.job.yml
+- template: ./jobs/VSEngSS-MicroBuild2022-1ES.job.yml
   parameters:
     DisplayName: DebuggerTesting
     JobTemplate:

eng/pipelines/MIDebugEngine-CI.yml

@@ -1,17 +1,6 @@
 ---
 name: $(Date:yyyMMdd).$(Rev:r)
 stages:
-- stage: CodeAnalysis
-  dependsOn: []
-  jobs:
-  - template: ./jobs/MSHosted-Windows.job.yml
-    parameters:
-      DisplayName: 'CodeAnalysis'
-      JobTemplate:
-      - template: ../templates/CodeAnalysis.template.yml
-        parameters:
-          Configuration: 'Lab.Debug'
-
 - stage: CI
   dependsOn: []
   variables:
@@ -20,19 +9,30 @@ stages:
   - name: TeamName
     value: MDDDebugger
   jobs:
-  - template: ./jobs/VSEngSS-MicroBuild2019-1ES.job.yml
+  - template: ./jobs/VSEngSS-MicroBuild2022-1ES.job.yml
     parameters:
       DisplayName: 'Lab.Debug'
       JobTemplate:
       - template: ../templates/Build.template.yml
         parameters:
           Configuration: 'Lab.Debug'
 
-  - template: ./jobs/VSEngSS-MicroBuild2019-1ES.job.yml
+  - template: ./jobs/VSEngSS-MicroBuild2022-1ES.job.yml
     parameters:
       DisplayName: 'Lab.Release'
       JobTemplate:
       - template: ../templates/Build.template.yml
         parameters:
           Configuration: 'Lab.Release'
+
+- stage: CodeAnalysis
+  dependsOn: [CI]
+  jobs:
+  - template: ./jobs/MSHosted-Windows.job.yml
+    parameters:
+      DisplayName: 'CodeAnalysis'
+      JobTemplate:
+      - template: ../templates/CodeAnalysis.template.yml
+        parameters:
+          Configuration: 'Lab.Debug'
 ...

eng/pipelines/VS-release.yml

@@ -3,7 +3,7 @@ name: $(Date:yyyMMdd).$(Rev:r)
 variables:
   - group: TSDTUSR
 jobs:
-- template: ./jobs/VSEngSS-MicroBuild2019-1ES.job.yml
+- template: ./jobs/VSEngSS-MicroBuild2022-1ES.job.yml
   parameters:
     DisplayName: 'VS_Release'
     JobTemplate:

eng/pipelines/VSCode-release.yml

@@ -6,7 +6,7 @@ stages:
 - stage: Windows
   dependsOn: []
   jobs:
-  - template: ./jobs/VSEngSS-MicroBuild2019-1ES.job.yml
+  - template: ./jobs/VSEngSS-MicroBuild2022-1ES.job.yml
     parameters:
       DisplayName: 'VSCode_Release'
       JobTemplate:
@@ -24,7 +24,7 @@ stages:
 - stage: OSX_ESRPSign
   dependsOn: [OSX_CodeSign]
   jobs:
-  - template: ./jobs/VSEngSS-MicroBuild2019-1ES.job.yml
+  - template: ./jobs/VSEngSS-MicroBuild2022-1ES.job.yml
     parameters:
       DisplayName: 'OSX Sign/Harden'
       JobTemplate:

eng/pipelines/jobs/MSHosted-Windows.job.yml

@@ -8,6 +8,7 @@ parameters:
 jobs:
 - job:
   displayName: ${{ parameters.DisplayName }}
+  timeoutInMinutes: 360
   pool:
     vmImage: 'windows-latest'
   steps:

eng/pipelines/jobs/VSEngSS-MicroBuild2019-1ES.job.yml → eng/pipelines/jobs/VSEngSS-MicroBuild2022-1ES.job.yml

@@ -8,7 +8,7 @@ jobs:
 - job:
   displayName: ${{ parameters.DisplayName }}
   pool:
-    name: VSEngSS-MicroBuild2019-1ES
+    name: VSEngSS-MicroBuild2022-1ES
     demands:
     - msbuild
     - visualstudio

eng/pipelines/steps/APIScan.yml

@@ -0,0 +1,29 @@
+parameters:
+  FolderToScan: '$(Pipeline.Workspace)\Lab.Release'
+
+steps:
+- task: CopyFiles@2
+  displayName: 'Copy Files to: $(Pipeline.Workspace)\ApiScanFiles'
+  inputs:
+    SourceFolder: ${{ parameters.FolderToScan }}
+    Contents: |
+      **\*Microsoft@(*.dll|*.pdb|*.exe)
+      **\*Newtonsoft@(*.dll|*.pdb|*.exe)
+      **\*OpenDebugAD7@(*.dll|*.pdb|*.exe)
+      **\*WindowsDebugLauncher@(*.dll|*.pdb|*.exe)
+      !**\*.resources.dll
+    TargetFolder: '$(Pipeline.Workspace)\ApiScanFiles'
+    CleanTargetFolder: true
+    OverWrite: true
+
+- task: securedevelopmentteam.vss-secure-development-tools.build-task-apiscan.APIScan@2
+  displayName: 'Run APIScan'
+  inputs:
+    softwareFolder: '$(Pipeline.Workspace)\ApiScanFiles'
+    softwareName: MIEngine
+    softwareVersionNum: '$(Build.BuildNumber)'
+    symbolsFolder: 'SRV*http://symweb;$(Pipeline.Workspace)\ApiScanFiles'
+    isLargeApp: false
+  continueOnError: true
+  env:
+    AzureServicesAuthConnectionString: runAs=App;AppId=$(ApiScanClientId);TenantId=$(ApiScanTenant);AppKey=$(MIEngineApiScan)

eng/pipelines/tasks/BinSkim.yml

@@ -0,0 +1,9 @@
+steps:
+- task: securedevelopmentteam.vss-secure-development-tools.build-task-binskim.BinSkim@3
+  displayName: 'Run BinSkim'
+  inputs:
+    InputType: Basic
+    AnalyzeTarget: '$(Pipeline.Workspace)\**\*.dll;$(Pipeline.Workspace)\**\*.exe'
+    AnalyzeVerbose: true
+    AnalyzeHashes: true
+    AnalyzeEnvironment: true

eng/pipelines/tasks/CSharp.yml

@@ -0,0 +1,11 @@
+steps:
+- task: securedevelopmentteam.vss-secure-development-tools.build-task-roslynanalyzers.RoslynAnalyzers@3
+  displayName: 'Run Roslyn Analyzers'
+  inputs:
+    continueOnError: true
+    msBuildVersion: 17.0
+    msBuildArchitecture: amd64
+    setupCommandLine: |
+      "%ProgramFiles%\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsMSBuildCmd.bat"
+    msBuildCommandline: |
+      msbuild $(Build.SourcesDirectory)\src\MIDebugEngine.sln /p:Platform="Any CPU" /p:Configuration="Release"

eng/pipelines/templates/Build.template.yml

@@ -19,6 +19,8 @@ steps:
   parameters:
     Configuration: ${{ parameters.Configuration }}
 
+- template: ../tasks/CSharp.yml
+
 # Used for localization
 - template: ../steps/CollectAndPublishBinaries.yml
   parameters:

eng/pipelines/templates/CodeAnalysis.template.yml

@@ -4,6 +4,18 @@ steps:
 
 - template: ../tasks/CredScan.yml
 
+- task: DownloadPipelineArtifact@2
+  displayName: Download Pipeline Artifact
+  inputs:
+    source: "current"
+    path: "$(Pipeline.Workspace)"
+
+- template: ../steps/APIScan.yml
+  parameters:
+    FolderToScan: $(Pipeline.Workspace)\Lab.Release
+
+- template: ../tasks/BinSkim.yml
+
 - template: ../tasks/PoliCheck.yml
 
 - template: ../tasks/SdtReport.yml