Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1374419: Address static analysis requirements for MIEngine #1305

Merged
merged 54 commits into from
Apr 20, 2022

Conversation

gc46
Copy link
Contributor

@gc46 gc46 commented Apr 18, 2022

Added the following to MIEngine:

  • APIScan
  • BinSkim
  • RoslynAnalyzers

@gc46
Copy link
Contributor Author

gc46 commented Apr 18, 2022

Note: I will remove the extraneous comments after this PR is approved/ready to go.

Copy link
Member

@WardenGnaw WardenGnaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: yaml files in tasks are supposed to contain one task, if you need multiple place them in `steps.

eng/pipelines/tasks/BinSkim.yml Outdated Show resolved Hide resolved
eng/pipelines/tasks/CSharp.yml Outdated Show resolved Hide resolved
eng/pipelines/tasks/CSharp.yml Outdated Show resolved Hide resolved
eng/pipelines/templates/Build.template.yml Outdated Show resolved Hide resolved
eng/pipelines/MIDebugEngine-CI.yml Outdated Show resolved Hide resolved
eng/pipelines/tasks/APIScan.yml Outdated Show resolved Hide resolved
@WardenGnaw
Copy link
Member

Be sure to also run the CodeAnalysis build after any changes.

eng/pipelines/tasks/CSharp.yml Outdated Show resolved Hide resolved
eng/pipelines/tasks/CSharp.yml Outdated Show resolved Hide resolved
eng/pipelines/tasks/APIScan.yml Outdated Show resolved Hide resolved
eng/pipelines/tasks/APIScan.yml Outdated Show resolved Hide resolved
eng/pipelines/tasks/APIScan.yml Outdated Show resolved Hide resolved
@gc46 gc46 merged commit 2358e32 into main Apr 20, 2022
@gc46 gc46 deleted the dev/gabchen/bug1374419 branch April 20, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants