Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] switch CRAN mirror to RStudio #5230

Merged
merged 1 commit into from
May 23, 2022
Merged

[ci] switch CRAN mirror to RStudio #5230

merged 1 commit into from
May 23, 2022

Conversation

jameslamb
Copy link
Collaborator

Created based on #5227 (comment).

This project's CI has been blocked for almost a day because cran.r-project.org has been down. According to one of CRAN's maintainers, this is because of an issue with an on-prem apache webserver running in a datacenter in Austria, and it won't be fixed until tomorrow because it's currently the weekend: https://stat.ethz.ch/pipermail/r-devel/2022-May/081750.html.

This PR proposes switching LightGBM's CI to use cran.rstudio.com instead for all its R CI jobs. That mirror is backed by a for-profit company and (I assume) supported by an on-call rotation of engineers who will quickly respond to availability issues. This blog post from 2013 hints how it is architected: https://www.rstudio.com/blog/rstudio-cran-mirror/. This is the default mirror set for everyone using R in the RStudio IDE, so I strongly expect it to have higher availability than cran.r-project.org.

Shouldn't we change links in documentation too?

I intentionally limited the scope of this PR to only LightGBM's CI jobs, and left its documentation pointing to cran.r-project.org untouched. I recall CRAN complaining in the past about "non-canonical URLs", and I see the following in https://cran.rstudio.com/doc/manuals/r-release/R-exts.html#Specifying-URLs

The canonical URL for a CRAN package is https://cran.r-project.org/package=pkgname

Writing R Extensions doesn't say whether CRAN is opinionated about which mirror is referenced in such links, but I don't want to risk a rejection by changing the existing README links.

My primary goal with this PR is to unblock LightGBM's development.

@jameslamb jameslamb marked this pull request as ready for review May 23, 2022 01:36
@jameslamb jameslamb requested a review from StrikerRUS as a code owner May 23, 2022 01:36
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for the quick fix!

@jameslamb jameslamb merged commit 0ebbf1e into master May 23, 2022
@jameslamb jameslamb deleted the ci/cran-mirror branch May 23, 2022 02:31
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants