Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automation: main-next integrate #18714

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Automation: main-next integrate #18714

merged 6 commits into from
Dec 8, 2023

Conversation

msfluid-bot
Copy link
Collaborator

main-next integrate PR

DO NOT MERGE THIS PR USING THE GITHUB UI.

The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:

  1. Acknowledge the pull request by adding a comment -- "Actively working on it".
  2. If there are no CI failures, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.
  3. If there are CI failures, check out the main-next-441c607 branch and make code changes to fix the failures.
  • You can ignore any failures in the Real service e2e test and Stress test pipelines. These pipelines are not required to pass to merge changes.
  1. Do NOT rebase or squash the main-next-441c607 branch: its history must be preserved. Always amend the HEAD commit using the following git commands:
  • git commit --amend -m "Automation: main-next integrate"
  • git push --force-with-lease

Once CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.

CraigMacomber and others added 6 commits December 4, 2023 14:58
@CraigMacomber
tree2: Simpify factory (#18630)
6b63bcd 
## Description

Reduce use of schema aware types in factory code-path where schema is
not actually known in most cases.
Additionally these schema aware types use the flex schema, which is not
available at compile time when used with class schema.

Inline extractContentIfProxy to remove redundant switch statement.

Fix nested lists.
@chentong7
[fix:devtools-example] Clean up pm2 related files (#18624)
c84fa79 
Removing all pm2 related files since we removed pm2 from
/devtools-example
@DLehenbauer
feat(tree2): workaround for AzureClient container schema (#18625)
2825301 
Adds a concrete class that implements ITree to unblock customers who
want to create SharedTree with AzureClient's ContainerSchema.

This is intended to be temporary until AB#6458 can be addressed.
@anthony-murphy
Tag protocol-definitions and server types necessary for IQuorum to be…
5082dd0 
… alpha (#18634)

This PR is preparation for changing the tagging on the IQuorum to be
alpha. All these types were automatically identified as transitive
dependency of the IQuorum class which will be made alpha in a later
review.

We will stage these commits and invite review, however review items will
generally be added to the backlog as future items, as these type updates
are necessary for the current state of the code base.

Co-authored-by: Tony Murphy <[email protected]>
@Josmithr
fix: Website build (#18628)
441c607 
Our blanket tagging of all API-members as (temporarily) `@internal` had
the unfortunate side-effect of (again, temporarily) breaking our API
docs generation for the website. In particular, we had logic that was
special casing certain API members of certain packages to bundle items
directly other packages' API docs.

We now have the option of doing this in a more general way via
functionality of api-extractor. We will light that functionality up for
`fluid-framework` and `@fluidframework/azure-client` in future PRs. For
now, this PR removes the special casing to fix the website build.
@msfluid-bot
Automation: main-next integrate
ae1f20c
@msfluid-bot msfluid-bot requested a review from a team as a code owner December 8, 2023 17:26
@msfluid-bot msfluid-bot requested review from a team as code owners December 8, 2023 17:26
@github-actions github-actions bot added community-contribution base: next PRs targeted against next branch labels Dec 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start http://localhost:1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://localhost:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

http://localhost:1313/docs/apis/location-redirection-utils/
- (1019:52) => http://localhost:1313/docs/apis/container-loader/-entrypoint (HTTP 404)
- (1019:52) => http://localhost:1313/docs/apis/container-loader/-entrypoint (HTTP 404)

http://localhost:1313/docs/apis/runtime-definitions/
- (1780:37) 'https://..' => https://datatracker.ietf.org/doc/html/rfc4122%29 (HTTP 404)
- (1780:37) 'https://..' => https://datatracker.ietf.org/doc/html/rfc4122%29 (HTTP 404)

http://localhost:1313/docs/apis/tree2/internaltypes/internalclasstreetypes-namespace/
- (1012:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)
- (1012:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)

http://localhost:1313/docs/apis/tree2/internaltypes/internalclasstreetypes/fieldkind-enum/
- (1012:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)
- (1012:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)

http://localhost:1313/docs/apis/tree2/internaltypes/internalclasstreetypes/fieldschema-class/
- (1014:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)
- (1014:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)

http://localhost:1313/docs/apis/tree2/internaltypes/makenominal-interface/
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)

http://localhost:1313/docs/apis/tree2/internaltypes/nodekind-enum/
- (1012:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)
- (1012:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)

http://localhost:1313/docs/apis/tree2/internaltypes/treelistnodebase-interface/
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)

http://localhost:1313/docs/apis/tree2/internaltypes/treenodeschemaclass-interface/
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)

http://localhost:1313/docs/apis/tree2/internaltypes/treenodeschemacore-interface/
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)

http://localhost:1313/docs/apis/tree2/internaltypes/treenodeschemanonclass-interface/
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)
- (1010:11) => http://localhost:1313/docs/apis/tree2/internaltypes (HTTP 302 => 404)
  - redirect path:
    - http://localhost:1313/docs/apis/tree2/internaltypes (302)
    - /docs/apis/tree2/internaltypes/ (404)

http://localhost:1313/docs/build/audience/
- (1002:11) => http://localhost:1313/docs/apis/audience/ (HTTP 404)

http://localhost:1313/docs/build/auth/
- (1002:11) => http://localhost:1313/docs/apis/auth/ (HTTP 404)

http://localhost:1313/docs/build/bundlers/
- (1002:11) => http://localhost:1313/docs/apis/bundlers/ (HTTP 404)
- (1032:233) 'here' => https://github.com/microsoft/FluidFramework/blob/a4c38234a920abe9b54b1c26a14c0a8e430cd3fa/packages/tools/webpack-fluid-loader/webpack.config.js#L37 (HTTP 200 but missing anchor)

http://localhost:1313/docs/build/container-states-events/
- (1002:11) => http://localhost:1313/docs/apis/container-states-events/ (HTTP 404)
- (1113:23) 'AttachSt..' => http://localhost:1313/docs/apis/container-definitions/#attachstate-enum (HTTP 200 but missing anchor)

http://localhost:1313/docs/build/containers/
- (1002:11) => http://localhost:1313/docs/apis/containers/ (HTTP 404)

http://localhost:1313/docs/build/data-modeling/
- (1002:11) => http://localhost:1313/docs/apis/data-modeling/ (HTTP 404)

http://localhost:1313/docs/build/dds/
- (1002:11) => http://localhost:1313/docs/apis/dds/ (HTTP 404)

http://localhost:1313/docs/build/experimental-features/
- (1002:11) => http://localhost:1313/docs/apis/experimental-features/ (HTTP 404)

http://localhost:1313/docs/build/overview/
- (1002:11) => http://localhost:1313/docs/apis/overview/ (HTTP 404)

http://localhost:1313/docs/build/packages/
- (1002:11) => http://localhost:1313/docs/apis/packages/ (HTTP 404)

http://localhost:1313/docs/build/tokenproviders/
- (1002:11) => http://localhost:1313/docs/apis/tokenproviders/ (HTTP 404)

http://localhost:1313/docs/concepts/architecture/
- (1002:11) => http://localhost:1313/docs/apis/architecture/ (HTTP 404)

http://localhost:1313/docs/concepts/handles/
- (1002:11) => http://localhost:1313/docs/apis/handles/ (HTTP 404)

http://localhost:1313/docs/concepts/signals/
- (1002:11) => http://localhost:1313/docs/apis/signals/ (HTTP 404)

http://localhost:1313/docs/concepts/summarizer/
- (1002:11) => http://localhost:1313/docs/apis/summarizer/ (HTTP 404)

http://localhost:1313/docs/concepts/tob/
- (1002:11) => http://localhost:1313/docs/apis/tob/ (HTTP 404)

http://localhost:1313/docs/data-structures/overview/
- (1002:11) => http://localhost:1313/docs/apis/overview/ (HTTP 404)

http://localhost:1313/docs/data-structures/sequences/
- (1002:11) => http://localhost:1313/docs/apis/sequences/ (HTTP 404)

http://localhost:1313/docs/data-structures/string/
- (1002:11) => http://localhost:1313/docs/apis/string/ (HTTP 404)

http://localhost:1313/docs/deployment/azure-frs/
- (1002:11) => http://localhost:1313/docs/apis/azure-frs/ (HTTP 404)

http://localhost:1313/docs/deployment/service-options/
- (1002:11) => http://localhost:1313/docs/apis/service-options/ (HTTP 404)
- (1037:72) 'Routerli..' => https://github.com/microsoft/FluidFramework/tree/main/server#readme (HTTP 200 but missing anchor)
- (1039:168) 'Routerli..' => https://github.com/microsoft/FluidFramework/tree/main/server#readme (HTTP 200 but missing anchor)

http://localhost:1313/docs/faq/
- (1095:87) 'Routerli..' => https://github.com/microsoft/FluidFramework/tree/main/server#readme (HTTP 200 but missing anchor)

http://localhost:1313/docs/recipes/angular/
- (1002:11) => http://localhost:1313/docs/apis/angular/ (HTTP 404)

http://localhost:1313/docs/recipes/collaborative-text-area/
- (1002:11) => http://localhost:1313/docs/apis/collaborative-text-area/ (HTTP 404)

http://localhost:1313/docs/recipes/node/
- (1002:11) => http://localhost:1313/docs/apis/node/ (HTTP 404)

http://localhost:1313/docs/recipes/react/
- (1003:11) => http://localhost:1313/docs/apis/react/ (HTTP 404)

http://localhost:1313/docs/recipes/teams/
- (1002:11) => http://localhost:1313/docs/apis/teams/ (HTTP 404)

http://localhost:1313/docs/recipes/temporary-storage/
- (1002:11) => http://localhost:1313/docs/apis/temporary-storage/ (HTTP 404)

http://localhost:1313/docs/recipes/vue/
- (1002:11) => http://localhost:1313/docs/apis/vue/ (HTTP 404)

http://localhost:1313/docs/recipes/web-components/
- (1002:11) => http://localhost:1313/docs/apis/web-components/ (HTTP 404)

http://localhost:1313/docs/start/examples/
- (1002:11) => http://localhost:1313/docs/apis/examples/ (HTTP 404)

http://localhost:1313/docs/start/quick-start/
- (1003:11) => http://localhost:1313/docs/apis/quick-start/ (HTTP 404)

http://localhost:1313/docs/start/tutorial/
- (1002:11) => http://localhost:1313/docs/apis/tutorial/ (HTTP 404)

http://localhost:1313/docs/testing/telemetry/
- (1002:11) => http://localhost:1313/docs/apis/telemetry/ (HTTP 404)
- (1037:3) 'ILoaderP..' => https://github.com/microsoft/FluidFramework/blob/main/packages/loader/container-loader/src/loader.ts#L313 (HTTP 200 but missing anchor)

http://localhost:1313/docs/testing/testing/
- (1002:11) => http://localhost:1313/docs/apis/testing/ (HTTP 404)

http://localhost:1313/docs/updates/v1.0.0/
- (1002:11) => http://localhost:1313/docs/apis/v1.0.0/ (HTTP 404)
- (1035:20) 'Connecti..' => http://localhost:1313/docs/apis/container-loader/#connectionstate-enum (HTTP 200 but missing anchor)


Stats:
  111406 links
    1246 destination URLs
       2 URLs ignored
       7 warnings
      37 errors

 ELIFECYCLE  Command failed with exit code 1.

@msfluid-bot
Copy link
Collaborator Author

⯅ @fluid-example/bundle-size-tests: +1 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 452.78 KB 452.78 KB ⯅ +2 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 239.23 KB 239.23 KB ■ No change
loader.js 166.81 KB 166.82 KB ⯅ +2 Bytes
map.js 46.7 KB 46.7 KB ⯅ +2 Bytes
matrix.js 144.75 KB 144.76 KB ⯅ +2 Bytes
odspDriver.js 90.35 KB 90.36 KB ⯅ +2 Bytes
odspPrefetchSnapshot.js 41.82 KB 41.82 KB ⯅ +2 Bytes
sharedString.js 165.55 KB 165.55 KB ■ No change
sharedTree2.js 288.9 KB 288.89 KB ⯆ -13 Bytes
Total Size 1.75 MB 1.75 MB ⯅ +1 Bytes

Baseline commit: 6304656

Generated by 🚫 dangerJS against ae1f20c

@sonalideshpandemsft sonalideshpandemsft merged commit ae1f20c into next Dec 8, 2023
39 checks passed
@sonalideshpandemsft sonalideshpandemsft deleted the main-next-441c607 branch December 8, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalideshpandemsft sonalideshpandemsft sonalideshpandemsft approved these changes

Assignees

@Josmithr Josmithr

Labels
base: next PRs targeted against next branch community-contribution main-next-integrate merge-ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@msfluid-bot @sonalideshpandemsft @Josmithr @CraigMacomber @chentong7 @DLehenbauer @anthony-murphy