Tag protocol-definitions and server types necessary for IQuorum to be alpha #18634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
public api change
anthony-murphy
added
the
fluid2alpha
Josmithr
reviewed
Dec 4, 2023
| @@ -150,7 +150,7 @@ export interface IProtocolState { | |||
| } | |||
|
|
|||
| /** | |||
| * @internal | |||
| * @alpha | |||
There was a problem hiding this comment.
Any docs we can add while we're here?
There was a problem hiding this comment.
i'm not sure what this is or how to describe it
Josmithr
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preparation for changing the tagging on the IQuorum to be alpha. All these types were automatically identified as transitive dependency of the IQuorum class which will be made alpha in a later review.
We will stage these commits and invite review, however review items will generally be added to the backlog as future items, as these type updates are necessary for the current state of the code base.