Automation: main-next integrate #18325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#18201) ## Description This PR reworks the existing `getRequestedRange` function into `getRequestedVersion`. The main change is that it returns the latest exact version requested instead of a semver range. This will be helpful when debugging compat testing since it will be more clear which version was used in testing. Logic pulled out form #17158 / #18087 ## Misc [AB#5929](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/5929)
## Description Cleanup typed/simple tree entry point to actually use a wrapper object for the view and expose what's needed for undo+redo and disposal. This should allow apps to use this simpler entry point. It also makes it possible to refer to TreeView types without needing access to the schema types, since its now parametric over the Proxy type instead. This is work toward having the "simple" public layer be more of a wrapper and less of an API subset, which better aligns with the differing data model and concepts between the public API and the implementation logic. The changes to the inventoryList sample show the main intended impact of these changes. ## Breaking Changes Code explicitly providing type parameters to TypedTree view will need to provide the proxy API instead. Users of the internal types and "schematize" need to call schemtizeInternal now. The typed tree types have been renamed.
This reverts commit 3bdedb9. The full compat is enabled for some tests that were not running in full compat, it broke the ci starting from: https://dev.azure.com/fluidframework/internal/_build/results?buildId=209931&view=results
…-insights-logger` to `@fluidframework/app-insights-logger` (#18252) Updates app insights example app dependency from `@fluid-internal/app-insights-logger` to `@fluidframework/app-insights-logger`. This was missed and didn't get caught in the build checks when the packages scope changed in a previous pr: https://github.com/microsoft/FluidFramework/pull/18239/files
PR #18198 added a dependency to the root that caused a peer dependency warning. The dep is not needed at the root, so I added it to the peer dep overrides.
## Description FieldNodes in editable-tree will no longer implicitly unbox. This means unboxing now removes at most 2 tree levels (leaf in an unboxing field) instead of potentially infinite. This simplifies typing a bit, fixes an issue where recursive field nodes were lossy when traversing enumerable own properties, and better aligns with how the Proxy API handles Lists. ## Breaking Changes Use `.content` to access the content of field nodes in cases where they no longer implicitly unbox to that.
…sing prettier fixes (#18261)
…r release groups (#18250)
|
Ack |
⯅ @fluid-example/bundle-size-tests: +7 Bytes
Baseline commit: 1a95198 |
|
This PR is ready to merge! Please review it and squash merge into |
tylerbutler
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
DO NOT MERGE THIS PR USING THE GITHUB UI.
The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:
git commit --amend -m "Automation: main-next integrate"git push --force-with-leaseOnce CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.