tree2: Remove FieldNode unboxing #18260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FieldNodes in editable-tree will no longer implicitly unbox.
This means unboxing now removes at most 2 tree levels (leaf in an unboxing field) instead of potentially infinite.
This simplifies typing a bit, fixes an issue where recursive field nodes were lossy when traversing enumerable own properties, and better aligns with how the Proxy API handles Lists.
Breaking Changes
Use
.content
to access the content of field nodes in cases where they no longer implicitly unbox to that.Reviewer Guidance
The review process is outlined on this wiki page.