Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree2: Remove FieldNode unboxing #18260

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

CraigMacomber
Copy link
Contributor

@CraigMacomber CraigMacomber commented Nov 10, 2023

Description

FieldNodes in editable-tree will no longer implicitly unbox.

This means unboxing now removes at most 2 tree levels (leaf in an unboxing field) instead of potentially infinite.
This simplifies typing a bit, fixes an issue where recursive field nodes were lossy when traversing enumerable own properties, and better aligns with how the Proxy API handles Lists.

Breaking Changes

Use .content to access the content of field nodes in cases where they no longer implicitly unbox to that.

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber CraigMacomber requested review from a team as code owners November 10, 2023 22:45
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree public api change Changes to a public API base: main PRs targeted against main branch labels Nov 10, 2023
@CraigMacomber CraigMacomber enabled auto-merge (squash) November 10, 2023 22:50
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: -124 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 447.51 KB 447.51 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 240.61 KB 240.61 KB No change
loader.js 178.94 KB 178.94 KB No change
map.js 48.06 KB 48.06 KB No change
matrix.js 141.84 KB 141.84 KB No change
odspDriver.js 90.27 KB 90.27 KB No change
odspPrefetchSnapshot.js 41.9 KB 41.9 KB No change
sharedString.js 162.75 KB 162.75 KB No change
sharedTree2.js 275.09 KB 274.97 KB -124 Bytes
Total Size 1.73 MB 1.73 MB -124 Bytes

Baseline commit: de08611

Generated by 🚫 dangerJS against 06c0024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants