-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added caching of event registration state to support unsubscribes across garbage collections #910
Merged
manodasanW
merged 22 commits into
master
from
manodasanw/fix_event_source_caching_leak2
Jul 24, 2021
Merged
Added caching of event registration state to support unsubscribes across garbage collections #910
manodasanW
merged 22 commits into
master
from
manodasanw/fix_event_source_caching_leak2
Jul 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the fix from #876 that was previously reverted.
In addition to the changes then, there is a couple more changes in this PR some of which are fixes for issues that were discovered related to the fix and others were improvements made to see if it resolves some test failures but were kept even if they didn't as they improved the code:
Note that the bulk of the event handler fixes can be seen in WinRT.cs
Fixes #842
Fixes #897
Fixes #858