Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delegates to use agile support from IObjectReference #858

Closed
manodasanW opened this issue Jun 3, 2021 · 2 comments · Fixed by #910
Closed

Update delegates to use agile support from IObjectReference #858

manodasanW opened this issue Jun 3, 2021 · 2 comments · Fixed by #910
Labels
bug Something isn't working
Milestone

Comments

@manodasanW
Copy link
Member

Delegates have their own logic today to make them agile. They can be updated to make use of the one that is now built into IObjectReference instead and not have to do custom logic. But given the delegates logic are in the projection it means we need to be able to guarantee that WinRT.Runtime has the changes that make it agile which we can only guarantee on the next assembly version increase.

We should also add actual non agile delegate tests as the current ones are considered agile even though they don't implement IAgileObject because they implement the free threaded marshaler.

See #844

@manodasanW manodasanW added bug Something isn't working AssemblyVersion change Requires assembly version change for WinRT.Runtime labels Jun 3, 2021
@manodasanW manodasanW added this to the Future milestone Jun 3, 2021
@manodasanW
Copy link
Member Author

@manodasanW
Copy link
Member Author

Note assembly version change was done in CsWinRT 1.3.0

@manodasanW manodasanW removed the AssemblyVersion change Requires assembly version change for WinRT.Runtime label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant