Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm watch script for TypeScript samples #949

Merged
merged 3 commits into from
Nov 18, 2018
Merged

Conversation

sgellock
Copy link
Member

Fixes #901 Yeoman generated echobot "watch" script does not watch

Proposed Changes

Update npm script watch command to work with typescript
PR #820 was a partical fix.
this PR includes fixes for all the typescript samples
it also fixes README.MD file casing to be README.md where this was broken

Testing

  • clone the samples repo
  • npm install any of the samples/javascript_typescript samples
  • npm run watch

a PR that changed the default bot name used by the yeoman generator from camelCase to kabob-case didn’t include an update to the documentation.

this corrects that
PR #820 was a partical fix.
this PR includes fixes for all the typescript samples
it also fixes README.MD file casing to be README.md where this was broken
@sgellock sgellock changed the title Sgellock/ts watch Fix npm watch script for TypeScript samples Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yeoman generated echobot "watch" script does not watch
1 participant