added concurrency dependency and watch script for typescript #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanvolum This looks good to me, but I would like to wait until a JS / TS person confirms... |
cleemullins
approved these changes
Nov 1, 2018
sgellock
added a commit
that referenced
this pull request
Nov 17, 2018
PR #820 was a partical fix. this PR includes fixes for all the typescript samples it also fixes README.MD file casing to be README.md where this was broken
sgellock
added a commit
that referenced
this pull request
Nov 18, 2018
* Fix bug introduced with yeoman nodejs template default bot name change a PR that changed the default bot name used by the yeoman generator from camelCase to kabob-case didn’t include an update to the documentation. this corrects that * Fixes #901 Yeoman generated echobot "watch" script does not watch PR #820 was a partical fix. this PR includes fixes for all the typescript samples it also fixes README.MD file casing to be README.md where this was broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #819
Proposed Changes
concurrently, a package that allows for running multiple commands concurrentlywatchscript:"watch": "concurrently --kill-others \"tsc -w\" \"nodemon ./lib/index.js\""This script runs tsc -w and nodemon concurrently, and kills both processes if either fails.