Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Various Samples][C#] Fix for bot files being uploaded w/ az bot publish #1245

Merged
merged 1 commit into from
Feb 19, 2019
Merged

[Various Samples][C#] Fix for bot files being uploaded w/ az bot publish #1245

merged 1 commit into from
Feb 19, 2019

Conversation

mdrichardson
Copy link
Contributor

Fixes microsoft/botbuilder-tools#965

Proposed Changes

Add:

<ItemGroup>
    <None Update="*.bot">
      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
    </None>
  </ItemGroup>

to the .csproj files that need it. Not having this was preventing .bot files from publishing (see issue)

Testing

.bot file gets published to Azure App Service:

image

stevengum
stevengum approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @johnataylor or @cleemullins?

@stevengum stevengum merged commit 06c5a86 into master Feb 19, 2019
@stevengum stevengum deleted the toolsIssue965fix branch February 19, 2019 22:27
This was referenced Feb 27, 2019
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 30, 2021
Closed
This was referenced Sep 15, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 16, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 31, 2021
Open
This was referenced Jun 20, 2023
Open
Open
Open
Open
This was referenced Dec 1, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@johnataylor johnataylor johnataylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdrichardson @johnataylor @stevengum