Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snyk] Fix for 1 vulnerabilities #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Fix for 1 vulnerabilities #36

wants to merge 1 commit into from

Conversation

snyk-bot
Copy link

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • experimental/adaptive-dialog/javascript_nodejs/03.core-bot/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 768/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 7.5		 Regular Expression Denial of Service (ReDoS)
SNYK-JS-ANSIREGEX-1583908		 Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: eslint The new version differs by 250 commits.
  • 145aec1 7.16.0
  • 83518a5 Build: changelog update for 7.16.0
  • a62ad6f Update: fix false negative of no-extra-parens with NewExpression (#13930)
  • f85b4c7 Fix: require-atomic-updates false positive across await (fixes #11954) (#13915)
  • 301d0c0 Fix: no-constant-condition false positives with unary expressions (#13927)
  • 555c128 Fix: false positive with await and ** in no-extra-parens (fixes #12739) (#13923)
  • d93c935 Docs: update JSON Schema links (#13936)
  • 8d0c93a Upgrade: [email protected] (#13920)
  • 9247683 Docs: Remove for deleted npm run profile script (#13931)
  • ab240d4 Fix: prefer-exponentiation-operator invalid autofix with await (#13924)
  • dc76911 Chore: Add .pre-commit-hooks.yaml file (#13628)
  • 2124e1b Docs: Fix wrong rule name (#13913)
  • 06b5809 Sponsors: Sync README with website
  • 26fc12f Docs: Update README team and sponsors
  • 902a032 7.15.0
  • 6356778 Build: changelog update for 7.15.0
  • 5c11aab Upgrade: @ eslint/esintrc and espree for bug fixes (refs #13878) (#13908)
  • 0eb7957 Upgrade: [email protected] (#13877)
  • 683ad00 New: no-unsafe-optional-chaining rule (fixes #13431) (#13859)
  • cbc57fb Fix: one-var autofixing for export (fixes #13834) (#13891)
  • 110cf96 Docs: Fix a broken link in working-with-rules.md (#13875)
  • 0cb81a9 7.14.0
  • fb3a594 Build: changelog update for 7.14.0
  • 5f09073 Update: fix 'skip' options in no-irregular-whitespace (fixes #13852) (#13853)

See the full diff

Package name: mocha The new version differs by 250 commits.
  • e1194ab Release v8.3.0
  • 9e75153 update CHANGELOG for v8.3.0 [ci skip]
  • 6dd12be match supporter's properties with supporter.js (#4569)
  • 9f2dd41 docs: add example of generating tests with a closure (#4494)
  • 9122909 Adds BigInt support to stringify util function (#4112)
  • 9878f32 Add file location when SyntaxError happens in ESM (#4557)
  • 84d0c96 Deps: update workerpool (#4566)
  • 3c2f82f GH actions: purge-expired-artifacts.yml (#4565)
  • 1a05ad7 chore(deps): upgrade all to latest stable (#4556)
  • c667d10 docs: fix javascript syntax errors (#4555)
  • 6eb3c3c Update dependencies yargs and yargs-parser (#4543)
  • 30d5b66 Fix workflow filter on pull-request event (#4550)
  • 6bcb89e Improve CI tests workflow (#4547)
  • c21a90f Fix present year in LICENSE (#4542)
  • c3c976b fixes require path
  • bc8ce05 add test for this.test.error() behavior in "after each" hooks
  • 78a41d1 Add GH Actions workflow status badge (#4503)
  • c6856ba add error code for test timeout errors
  • 6d3fe26 add support for typescript-style docstrings
  • 025fc2e run browser tests on GHA
  • b1f26e2 handful of improvements to integration tests
  • 59f31e3 fix typo in comment [ci skip]
  • d1781b3 refactor collect-files to be a little more simple
  • 185cada Release v8.2.1

See the full diff

Package name: nodemon The new version differs by 16 commits.

See the full diff

Package name: nyc The new version differs by 55 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

@snyk-bot
fix: experimental/adaptive-dialog/javascript_nodejs/03.core-bot/packa…
b2f6199 
…ge.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908
@pull-request-quantifier-deprecated
Copy link

This PR has 8 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +4 -4
Percentile : 3.2%

Total files changed: 1

Change summary by file extension:
.json : +4 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snyk-bot