Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properties should support concurrency #289

Merged
merged 1 commit into from
Aug 20, 2016
Merged

properties should support concurrency #289

merged 1 commit into from
Aug 20, 2016

Conversation

SergeyKanzhelev
Copy link
Contributor

@abaranch
Copy link
Contributor

:shipit:

@dnduffy
Copy link
Member

dnduffy commented Aug 19, 2016 •
edited
Loading

It works, I sure hope we don't forget about it and have someone accidentally change it in future.
Can you add a unit test which asserts that the type of the IDictionary provided in key types is ConcurrentDictionary as expected to be safe?
:shipit:
P.S. What I mean is that because it is fixed as an after generation step it isn't obvious when/where/how it is happening.

@SergeyKanzhelev SergeyKanzhelev merged commit ad21097 into publicSchemaUpdate Aug 20, 2016
@SergeyKanzhelev SergeyKanzhelev deleted the sergkanz/concurrency branch August 20, 2016 20:31
TimothyMothra pushed a commit that referenced this pull request Oct 25, 2019
Merge pull request #289 from microsoft/develop
31cdea7 
Develop to master 2.10.0 stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergeyKanzhelev @abaranch @dnduffy @msftclas