New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make properties collection of types thread-safe #288

Closed

SergeyKanzhelev opened this issue Aug 19, 2016 · 0 comments

Labels

Contributor

SergeyKanzhelev commented Aug 19, 2016

Today properties collection of telemetry types is not thread safe: https://github.com/Microsoft/ApplicationInsights-dotnet/blob/publicSchemaUpdate/src/Core/Managed/Shared/Extensibility/Implementation/External/RequestData_types.cs#L74

Need to make sure that actual interface object uses thread safe properties collection (https://github.com/Microsoft/ApplicationInsights-dotnet/blob/master/src/Core/Managed/Shared/DataContracts/RequestTelemetry.cs#L155

SergeyKanzhelev added enhancement oss-collab labels

SergeyKanzhelev mentioned this issue

properties should support concurrency #289

Merged

abaranch added the p1 label

SergeyKanzhelev closed this as completed

TimothyMothra pushed a commit that referenced this issue


          Upgrade base SDK and bump version to 2.10.0 (#288)

0ab0207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment