Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site][Accessibility] Update link indicators to underline on hover #5374

Merged
merged 8 commits into from
Feb 22, 2021
Merged

[Site][Accessibility] Update link indicators to underline on hover #5374

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6498711
[Site][Accessibility] Added underlines to links that don't have chevrons
Feb 9, 2021
594920a
Merge branch 'main' into rebecch/footerunderlines
Feb 10, 2021
ec92907
Merge branch 'main' into rebecch/footerunderlines
Feb 10, 2021
1360839
Merge branch 'main' into rebecch/footerunderlines
Feb 18, 2021
308b24b
Updates from feedback from the accessibility team
Feb 18, 2021
88186f2
Update to limit the blue in the footer to only the Hexo and Storybook…
Feb 18, 2021
5f2d3f2
Merge branch 'main' into rebecch/footerunderlines
Feb 19, 2021
b2103a0
Merge branch 'main' into rebecch/footerunderlines
Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/nodejs/adaptivecards-site/themes/adaptivecards/layout/_partial/footer.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@
<div class="w3-cell w3-container w3-margin-top w3-mobile" style="width: 300px">
<h6>Learn</h6>
<% for (var link of config.footer.learn_links) { %>
<p><a href="<%- url_for(link.href) %>"><%- link.title %> <i class="fas fa-chevron-right"></i></a></p>
<p><a class="ac-link-with-chevron" href="<%- url_for(link.href) %>"><%- link.title %> <i class="fas fa-chevron-right"></i></a></p>
<% } %>
</div>

<div class="w3-cell w3-container w3-margin-top w3-mobile" style="width: 300px; max-width: 300px">
<div class="w3-cell-row" style="margin-top: 6px;">
<h6 class="w3-cell w3-cell-middle">Blog</h6>
<a class="w3-cell w3-cell-middle w3-small" style="padding-left: 20px;"
<a class="w3-cell w3-cell-middle w3-small ac-link-with-chevron" style="padding-left: 20px;"
href="<%- url_for('blog') %>">Read more <i class="fa fa-chevron-right"></i></a>
</div>

<% site.posts.sort("-date").slice(0, 4).each(function(post) { %>
<div class="w3-margin-top">
<a href="<%- config.root %><%- post.path %>"><%- post.title %> <i class="fas fa-chevron-right"></i></a>
<a class="ac-link-with-chevron "href="<%- config.root %><%- post.path %>"><%- post.title %> <i class="fas fa-chevron-right"></i></a>
<p class="post-subtitle"><%- post.subtitle %></p>
</div>
<% }); %>
Expand Down
2 changes: 1 addition & 1 deletion source/nodejs/adaptivecards-site/themes/adaptivecards/layout/_partial/home-section.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<% } %>
<h2><%- title %></h2>
<h3><%- subtitle %></h3>
<a href="<%- learnMoreLink %>"><%- learnMoreTitle %> <i class="fas fa-chevron-right"></i></a>
<a class="ac-link-with-chevron" href="<%- learnMoreLink %>"><%- learnMoreTitle %> <i class="fas fa-chevron-right"></i></a>
</div>
<div class="w3-container w3-cell w3-mobile section-video" >
<video data-autoplay="true" playsinline muted style="width: 100%; margin-bottom: -8px" data-loop-delay="<%= typeof videoLoopDelay !== 'undefined' ? videoLoopDelay : '' %>">
Expand Down
9 changes: 7 additions & 2 deletions source/nodejs/adaptivecards-site/themes/adaptivecards/source/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,11 +617,11 @@ dir {
font-size: 15px;
line-height: 29px;
font-weight: 600;
text-decoration: underline;
}

.homepage a:hover {
color: blue;
text-decoration: none;
}

/* .fa-chevron-right {
Expand Down Expand Up @@ -654,11 +654,11 @@ dir {
font-size: 14px;
font-weight: 600;
white-space: nowrap;
text-decoration: underline;
}

.ac-footer a:hover {
color: #6b6b6b;
text-decoration: none;
}

.ac-footer .post-subtitle {
Expand All @@ -679,3 +679,8 @@ input.bigbox {
transform: scale(2.5);
transform-origin: left;
}

.ac-link-with-chevron
{
text-decoration: none!important;
}