Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site][Accessibility] Update link indicators to underline on hover #5374

Merged
merged 8 commits into from
Feb 22, 2021

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Feb 9, 2021

Related Issue

Fixes ADO 30927092

Description

Per thread with accessibility team, this fix makes the following changes:

  • Storybook and Hexo links are now blue and underline on hover
  • All site links now underline on hover

How Verified

Visually confirmed expected behavior:

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Feb 9, 2021

Hi @RebeccaAnne. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206 paulcam206 self-requested a review February 10, 2021 18:45
@ghost ghost added the no-recent-activity label Feb 15, 2021
@ghost ghost assigned paulcam206 Feb 15, 2021
@ghost
Copy link

ghost commented Feb 15, 2021

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Feb 18, 2021
@ghost
Copy link

ghost commented Feb 18, 2021

Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness.

@RebeccaAnne
Copy link
Contributor Author

Will be updating this fix with latest guidance from the accessibility team.

@RebeccaAnne RebeccaAnne changed the title [Site][Accessibility] Added underlines to links that don't have chevrons [Site][Accessibility] Update link indicators to underline on hover Feb 18, 2021
@RebeccaAnne RebeccaAnne merged commit 71268b8 into main Feb 22, 2021
@RebeccaAnne RebeccaAnne deleted the rebecch/footerunderlines branch February 22, 2021 17:04
@golddove golddove added this to the 21.02 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants