-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing validation for the InputFormWithLabels sample #5238
Conversation
Hi @matthidinger. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
Hi @paulcam206; Thanks for reviewing this previously stale pull request. Resetting staleness. @matthidinger FYI. |
Hi @matthidinger. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
Hi @matthidinger; Thanks for taking action on your previously stale pull request. Resetting staleness. |
Hi @matthidinger. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
Hi @matthidinger; Thanks for taking action on your previously stale pull request. Resetting staleness. |
Description
Fixes #5201
This sample validation is broken because of the binding expression in the
id
property. Change the binding such that the id comes from the data as opposed to anif
condition.How Verified
Manually tested on site.
https://adaptivecardsci.z5.web.core.windows.net/pr/5238/samples/InputFormWithLabels.html
Microsoft Reviewers: Open in CodeFlow