Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavsScript ] Required Input validation not working properly on "Input Form with Labels" sample #5201

Closed
1 task done
matthidinger opened this issue Dec 17, 2020 · 3 comments · Fixed by #5238
Closed
1 task done
Assignees
Labels
Area-Samples Fixes related to our test samples Bug
Milestone

Comments

@matthidinger
Copy link
Member

matthidinger commented Dec 17, 2020

Platform

What platform is your issue or question related to? (Delete other platforms).

  • JavaScript

Details

http://adaptivecards-ci.azurewebsites.net/samples/InputFormWithLabels.html

Loaded this card on the website, and the Name and Email fields are marked required, but input validation did not fire. Possibly because they are created with data binding expressions?

image

@ghost ghost added this to the 21.01 milestone Dec 17, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Dec 17, 2020
@ghost
Copy link

ghost commented Dec 17, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@shalinijoshi19
Copy link
Member

@matthidinger the regex seems to be busted for that sample for starters; I was just on it as well!

image

Here's the fixes to the regex for basic email + name formats:

image

@shalinijoshi19 shalinijoshi19 self-assigned this Dec 17, 2020
@ghost
Copy link

ghost commented Dec 17, 2020

Hi @matthidinger. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Samples Fixes related to our test samples Bug
Projects
None yet
2 participants