Fixing the regex used in our InputFormWithLabels sample #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golddove
suggested changes
Dec 21, 2020
There was a problem hiding this comment.
Linked issue still seems to be present in the generated test site.
ghost
added
|
Hi @shalinijoshi19. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @shalinijoshi19; Thanks for taking action on your previously stale pull request. Resetting staleness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5201
Description
The regex for the Name & email fields had typos. Rewriting these to accept basic names (no special characters for the purpose of the sample) and email format.
Sample Card
v1.3\Scenarios\InputFormWithLabels.json sample
How Verified
Microsoft Reviewers: Open in CodeFlow