Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Attempt to get FullHttpRequest support in Servlet requests #471

Merged
merged 5 commits into from
Jun 7, 2023
+481 −7
Merged

wip: Attempt to get FullHttpRequest support in Servlet requests #471

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
efac178
Attempt to get FullHttpRequest support in Servlet requests
timyates Jun 5, 2023
0bc7ca8
Address feedback
timyates Jun 5, 2023
a54657e
Review comments
timyates Jun 7, 2023
1bb046f
Move byte[] backed ByteBuffer into servlet-core
timyates Jun 7, 2023
72b9488
Kick github with a blank commit to see if it updates the pr
timyates Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review comments
@timyates
timyates committed Jun 7, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit a54657e018874a4a4a178a9b3181e61003bdff57
6 changes: 4 additions & 2 deletions servlet-engine/src/main/java/io/micronaut/servlet/engine/DefaultServletHttpRequest.java
View file
Original file line number Diff line number Diff line change
@@ -436,7 +436,9 @@ public boolean isFull() {
@Override
public ByteBuffer<?> contents() {
if (bodyIsReadAsync) {
LOG.debug("Body is read asynchronously, cannot get contents");
if (LOG.isDebugEnabled()) {
LOG.debug("Body is read asynchronously, cannot get contents");
}
return null;
}
try {
@@ -451,7 +453,7 @@ public ByteBuffer<?> contents() {
public ExecutionFlow<ByteBuffer<?>> bufferContents() {
ByteBuffer<?> contents = contents();
if (contents == null) {
throw new IllegalStateException("Cannot buffer contents asynchronously");
return null;
}
return ExecutionFlow.just(contents);
}