wip: Attempt to get FullHttpRequest support in Servlet requests #471
Conversation
| @Override | ||
| public ByteBuffer<?> contents() { | ||
| if (bodyIsReadAsync) { | ||
| throw new IllegalStateException("Cannot fetch body content of an asynchronous request"); |
There was a problem hiding this comment.
should return null on failure (bufferContents should error though)
| public ExecutionFlow<ByteBuffer<?>> bufferContents() { | ||
| ByteBuffer<?> contents = contents(); | ||
| if (contents == null) { | ||
| throw new IllegalStateException("Cannot buffer contents asynchronously"); |
There was a problem hiding this comment.
i changed my mind on this, please return null in this case (null, not ExecutionFlow.just(null)). I will adjust the supermethod in core accordingly.
There was a problem hiding this comment.
| throw new IllegalStateException("Cannot buffer contents asynchronously"); | |
| return null; |
servlet-engine/src/main/java/io/micronaut/servlet/engine/DefaultServletHttpRequest.java
Outdated
Show resolved
Hide resolved
| return ExecutionFlow.just(contents); | ||
| } | ||
|
|
||
| private final class ServletByteBuffer<T> implements ByteBuffer<T> { |
There was a problem hiding this comment.
should not we move this class to servlet-core so that we are able to use it in the serverless implementations?
There was a problem hiding this comment.
Maybe extract it into its own file and annotate it with @Experimental
There was a problem hiding this comment.
Done in 1bb046f
Which isn't showing up in the PR for unknown reasons... github status is lying I suspect
|
SonarCloud Quality Gate failed. |
No description provided.