Handle multiple named Redis servers #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have asked @rjaros87 to take a look at this fix, as I keep not quite covering all the cases 😞 |
sdelamo
requested changes
Apr 12, 2023
crac/src/main/java/io/micronaut/crac/resources/redis/RedisClientResource.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
sdelamo
approved these changes
Apr 12, 2023
sdelamo
added a commit
that referenced
this pull request
Jun 1, 2023
* use Gradle Kotlin DSL * Update slsa-framework/slsa-github-generator action to v1.3.0 (#42) * ci: distribution temurin cla provenance (#44) * Update stefanzweifel/git-auto-commit-action action to v4.15.4 (#43) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * build: Micronaut Framework 3.7.4 * build: spock 2.2-groovy-3.0 * doc: eager singletons and inject HttpClient (#66) See micronaut-projects/micronaut-test#716 * ci: projectVersion 1.2.0-SNAPSHOT * ci: githubCoreBranch 3.9.x * build: Micronaut Framework 3.8.5 * build: Micronaut Test 3.8.2 * build: Spock 2.3-groovy-3.0 * wip DataSourceResolver * Convert Delegating datasource and filter non-hikari contents * Test * Test to ensure DBCP still works and isn't supported * Try to downgrade Jooq * remove @Inject BeanContext ctx * Simplify composite (#73) * Simplify composite * Extract common code to method --------- Co-authored-by: Tim Yates <[email protected]> * build: Micronaut Framework 3.8.6 * build: Micronaut Test 3.9.1 * ci: GitHub Actions sync * [skip ci] Release v1.2.0 * Back to 1.2.1-SNAPSHOT * Redis support for CRaC (#78) * wip: Redis support for CRaC - Currently doesn't work for `@Cacheable` tags - Needs manual testing with a proper app * Add base buildSrc plugin * Add config and tests * Docs * Update src/main/docs/guide/resource/redis.adoc Co-authored-by: Sergio del Amo <[email protected]> --------- Co-authored-by: Sergio del Amo <[email protected]> * [skip ci] Release v1.2.1 * Back to 1.2.2-SNAPSHOT * bug: StatefulRedisPubSubConnection beans are not supported (#91) * Also destroy StatefulRedisPubSubConnectionResource beans As raised here #63 (comment) StatefulRedisPubSubConnection beans were not destroyed during checkpointing, and so we were getting connection closed errors. * Fix. There are no PubSub beans, they are all connection beans * Reduce duplication * Checkstyle... * Naming * Visibility * [skip ci] Release v1.2.2 * Back to 1.2.3-SNAPSHOT * Handle multiple named Redis servers (#92) * Handle multiple named Redis servers * Remove debug * Fix imports * Remove deprecated experimental classes and add accepted-api-changes * [skip ci] Release v1.2.3 * Back to 1.2.4-SNAPSHOT * Document checkpoint simulator, with java/groovy/kotlin examples (#117) * Document checkpoint simulator, with java/groovy/kotlin examples closes #115 * documentation for CheckpointSimulator * Java/Groovy/Kotlin docs examples * Extract documented classes to get rid of static --------- Co-authored-by: Tim Yates <[email protected]> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: micronaut-build <[email protected]> Co-authored-by: Tim Yates <[email protected]> Co-authored-by: micronaut-build <[email protected]> Co-authored-by: Dean Wette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix for handling Pubsub connections in Redis was incorrect and would fail when multiple Redis servers were defined in the configuration.
#89 (comment)
To better handle this situation, this PR switches to defining CRaC Resources based on the Redis configuration (as this is how the connections are built by micronaut-redis, it seems a more sensible solution)
The old Client, Connection and PubSub connection resources have been deprecated, and disabled by adding a Requirement that they themselves are absent from the classpath. It was done this way to maintain binary compatibility with 1.2.2