-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bean context classloader for Jackson #10121
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
jackson-databind/src/test/groovy/io/micronaut/jackson/JacksonClassloaderSetupSpec.groovy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
/* | ||
* Copyright 2017-2023 original authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package io.micronaut.jackson | ||
|
||
import io.micronaut.annotation.processing.test.AbstractTypeElementSpec | ||
import io.micronaut.context.ApplicationContext | ||
import io.micronaut.core.type.Argument | ||
import io.micronaut.json.JsonMapper | ||
|
||
class JacksonClassloaderSetupSpec extends AbstractTypeElementSpec { | ||
|
||
void "test Jackson classloader"() { | ||
given: | ||
def context = buildContext('test.Animal',""" | ||
package test; | ||
|
||
import com.fasterxml.jackson.annotation.*; | ||
|
||
@JsonTypeInfo(use = JsonTypeInfo.Id.MINIMAL_CLASS, defaultImpl = Dog.class) | ||
interface Animal { | ||
String getName(); | ||
} | ||
|
||
class Dog implements Animal { | ||
private String name; | ||
private double barkVolume; | ||
|
||
@Override | ||
public String getName() { | ||
return name; | ||
} | ||
public void setName(String name) { | ||
this.name = name; | ||
} | ||
public void setBarkVolume(double barkVolume) { | ||
this.barkVolume = barkVolume; | ||
} | ||
public double getBarkVolume() { | ||
return barkVolume; | ||
} | ||
} | ||
|
||
class Cat implements Animal { | ||
private String name; | ||
private int lives; | ||
private boolean likesCream; | ||
public String getName() { | ||
return name; | ||
} | ||
public void setName(String name) { | ||
this.name = name; | ||
} | ||
public int getLives() { | ||
return lives; | ||
} | ||
public void setLives(int lives) { | ||
this.lives = lives; | ||
} | ||
public void setLikesCream(boolean likesCream) { | ||
this.likesCream = likesCream; | ||
} | ||
public boolean isLikesCream() { | ||
return likesCream; | ||
} | ||
} | ||
""", true) | ||
|
||
when: | ||
JsonMapper jsonMapper = context.getBean(JsonMapper) | ||
|
||
def dogBean = jsonMapper.readValue('{"@c":".Dog","name":"Fred","barkVolume":1.1}', argumentOf(context, 'test.Animal')) | ||
def catBean = jsonMapper.readValue('{"@c":".Cat","name":"Joe","lives":9,"likesCream":true}', argumentOf(context, 'test.Animal')) | ||
|
||
then: | ||
dogBean.name == "Fred" | ||
dogBean.barkVolume == 1.1d | ||
catBean.name == "Joe" | ||
catBean.likesCream | ||
catBean.lives == 9 | ||
|
||
cleanup: | ||
context.close() | ||
} | ||
|
||
Argument<Object> argumentOf(ApplicationContext context, String name) { | ||
return Argument.of(context.classLoader.loadClass(name)) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some cases where
ObjectMapperFactory
is used without the bean context