Use bean context classloader for Jackson #10121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawkat
approved these changes
Nov 15, 2023
| @@ -143,6 +147,10 @@ public ObjectMapper objectMapper(@Nullable JacksonConfiguration jacksonConfigura | |||
| objectMapper.findAndRegisterModules(); | |||
| } | |||
| objectMapper.registerModules(jacksonModules); | |||
| if (beanContext != null) { | |||
There was a problem hiding this comment.
There are some cases where ObjectMapperFactory is used without the bean context
|
@yawkat Any idea why the tests are failing? |
|
looks like flakey tests, incl #10104 |
graemerocher
approved these changes
Nov 15, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiled tests fail for Jackson subtypes