Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove micronaut-micronaut- duplication #522

Closed
wants to merge 1 commit into from

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Mar 3, 2023

When standardized project names are in used, binary compatibility checks fail because the micronaut- prefix is added to the artifact id, resulting in a double micronaut-micronaut- prefix.

It seems the solution proposed #521 has some drawbacks
@melix what do you think about going this simpler route?

@sdelamo sdelamo requested a review from melix March 3, 2023 06:54
Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work. This is actually half of the fix I implemented, except that I used the moduleNameOf method for deduplicating. The problem is that once you have fixed that deduplication, it surfaces a bug in Gradle where you cannot resolve, within the same project, a configuration which contains a binary dependency on the same project (same GAV coordinates). Hence my fix instead.

@sdelamo sdelamo closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants