Fix binary compatibility checks #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When standardized project names are in used, binary compatibility checks fail because the `micronaut-` prefix is added to the artifact id, resulting in a double `micronaut-micronaut-` prefix. This commit fixes that, but by doing so, it also introduces another bug which is related to Gradle preventing the resolution of a library which corresponds to the current project, in a different version. In order to workaround this bug, we use the root project detached configurations, which isn't great, because it reaches out to another project's state.
sdelamo
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When standardized project names are in used, binary compatibility checks fail because the
micronaut-prefix is added to the artifact id, resulting in a doublemicronaut-micronaut-prefix. This commit fixes that, but by doing so, it also introduces another bug which is related to Gradle preventing the resolution of a library which corresponds to the current project, in a different version.In order to workaround this bug, we use the root project detached configurations, which isn't great, because it reaches out to another project's state.
Fixes the error seen at micronaut-projects/micronaut-security#1240 (comment)