Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Device Sync request #2621

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

DaVinci9196
Copy link
Contributor

Added a device information synchronization request after logging in to the account to solve the problem of missing data in some request interfaces that rely on device information.
For example, when there is no device synchronization in the /assetModuleDelivery request in #2506 , some games lack resource package data returned.

@ale5000-git
Copy link
Member

@DaVinci9196
This PR may be very useful for many people but others may not like it.
Could you please add an option to enable/disable Device Sync request?

@ale5000-git
Copy link
Member

ale5000-git commented Dec 12, 2024

@mar-v-in
Maybe we need to add IMEI and IMSI to Device profile code to generate random values at first time but consistent between requests.

@mar-v-in
Copy link
Member

Maybe we need to add IMEI and IMSI to Device profile code to generate random values at first time but consistent between requests.

I was considering the same, but in most cases IMEI and IMSI are not required anyway (because of wifi-only tablets). But yes, in the long run that would be a good idea.

@ale5000-git
Copy link
Member

ale5000-git commented Dec 12, 2024

If I'm not wrong in this PR it send the real IMSI that could be used to identify the SIM.

@ale5000-git
Copy link
Member

ale5000-git commented Dec 12, 2024

@DaVinci9196
Could we spoof a device without SIM that is connected only via Wireless? (so avoiding IMSI and operator informations)

@mar-v-in
Copy link
Member

@ale5000-git The current code puts the android id where probably the IMSI belongs. There is no calling of getSubscriberId, but also it wouldn't have permission to read it anyway.

@ale5000-git
Copy link
Member

ale5000-git commented Dec 12, 2024

I was considering the same, but in most cases IMEI and IMSI are not required anyway (because of wifi-only tablets). But yes, in the long run that would be a good idea.

Devices without SIM slot are rare I think and devices with SIM slot but empty are more common but still have IMEI (device with 4 SIM slots have 4 IMEI even if the slots are unused).
So I think we should at least have the number of sim slot in the profile xml and the device profile code should fake a corresponding number of IMEI.

@DaVinci9196
Copy link
Contributor Author

Accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants