-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AssetModuleService #2506
Conversation
Hey, can this be released on some canary build? I was running waze on a device thwt don't have play services, and installed gms core but waze was unable to download some files that I think it's because of this missing implementation. I would love to test this. |
If possible, you can first check whether this service is called. At present, we only found that the game will download resource files through this service. |
Device Sync is not related to Asset Modules, please put it in a separate pull request. |
For example, the resource data returned by League of Legends depends on the device synchronization request #2621. |
vending-app/src/main/kotlin/com/google/android/finsky/DownloadManager.kt
Outdated
Show resolved
Hide resolved
@mar-v-in During our testing, we discovered anomalies in the game's resource download and installation process and have fixed them. |
…onnection. It is necessary to send progress change broadcasts in real time, otherwise the progress bar will be stuck.
… an error message
…nload progress in notification bar.
Solve the problem that some games cannot obtain sub-packaged downloaded content.
…urce installation
Formatting Code
This is mostly to understand the protocol details, we should eventually factor this out into a standalone library.
Implement deduplication processing for broadcast data to fix resource download and installation anomalies.
… sub-package content multiple times, the same sessionId causes repeated calls.
a08aa0f
to
6d4d24f
Compare
Thanks for the work, I merged this despite a few issues already known, which I linked above, so that we get this rolling for testing in 0.3.5 and won't divert further from the main branch. |
The three applications were tested and can be downloaded and installed normally through the service.
e.g. com.wb.goog.mkx , com.gameloft.android.ANMP.GloftDYHM , jp.konami.pesam