Deprecate ProtocolExecution class and related slots
#2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
sierra-moxon
approved these changes
Feb 6, 2025
|
Looks great, thanks Bea. For reference, #2337 <- issue for moving these elements to the deprecated.yaml after the next release. |
kheal
approved these changes
Feb 6, 2025
|
Thank you Sierra and Katherine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
deprecationannotations to the definitions for classProtocolExecution, enumProtocolCategoryEnum, and slotsprotocol_execution_setandhas_process_parts. It also removesProtocolExecutionfrom the example data files andprotocol_execution_setfrom the Makefile.