GeoLocationNameValue with examples

[turbomam]

I sneaked in a few white-space auto-reformats

[github-actions]

PR Preview Action v1.5.0
🚀 Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2308/
on branch gh-pages at 2025-01-09 18:04 UTC

[turbomam]

I wanted to use see_alsos for the INSDC and CIA links for country_or_sea's links but got

ValueError: https://www.cia.gov/the-world-factbook/ and http://unstats.un.org/unsd/methods/m49/m49.htm is not a valid URI or CURIE

[aclum]

This is acceptable to me but needs coordination with code that generate biosample records @sujaypatil96 @pkalita-lbl @corilo
we would also need a migrator for existing data FYI @eecavanna @brynnz22

[eecavanna]

Hi @turbomam, it's not clear to me what the two operands of the OR are here.

Interpretation 1 (I added EITHER to mark the first operand):

...a region that is "EITHER" a [...] subdivision [...] OR an unambiguous...

Interpretation 2 (I added "EITHER" to mark the first operand):

...a region that is a [...] subdivision of EITHER a [...] value, OR an unambiguous...

[eecavanna]

A few lines above this, we have the word sea without quotes.

MIxS states that country or sea names...

I don't know why it is enclosed in quotes here.

...within an ocean or "sea".

[eecavanna]

Unrelated to this PR (I'm commenting on it while it's in my attention): I don't understand this sentence.

The value for any value of a attribute for a sample.

[eecavanna]

we would also need a migrator for existing data FYI

Thanks for the heads up. In this PR, so far, I am not seeing any schema changes that would make existing data invalid. Maybe those schema changes are coming soon (or I'm overlooking them here).

[aclum]

also need input from kitware folks since this would impact nmdc-server code. @jeffbaumes @naglepuff @marySalvi

[turbomam]

@eecavanna the need for the migration is based on the fact that the range of geo_loc_name will change from string to an instance of this class.

[eecavanna]

Thanks, @turbomam. That makes sense to me. I assume that changing the range of geo_log_name will happen via a separate PR, since I don't see it in the diff of this PR.