1337 add slot bulk elect conductivity #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added bulk_elect_conductivity slot to Biosample in nmdc.yaml for EMSL compatibility.
Added example value from actual EMSL data, removed unnecessary alias.
turbomam
requested changes
Nov 15, 2023
| @@ -1081,6 +1081,7 @@ classes: | |||
| - sample_link | |||
|
|
|||
| ## EMSL slots | |||
| - bulk_elect_conductivity | |||
There was a problem hiding this comment.
will you be moving all existing EMSL slots underneath this comment?
There was a problem hiding this comment.
I think it's useful to organize, so we know where it came from. The new slots will go here.. most of the slots are MIxS & already exist
mslarae13
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "bulk_elect_conductivity" slot definition to nmdc.yaml, also added it to the list of slots in the Biosample class definition. This slot is being added for EMSL metadata compatibility.