Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chunkSize documented #818

Merged
merged 2 commits into from
Jul 23, 2020
Merged

chunkSize documented #818

merged 2 commits into from
Jul 23, 2020

Conversation

akshaybabloo
Copy link
Contributor

closes #673

@akshaybabloo akshaybabloo mentioned this pull request Jul 23, 2020
Merged
10 tasks
pokoli
pokoli reviewed Jul 23, 2020
View reviewed changes
docs/docs.html Outdated
<code>chunkSize</code>
</td>
<td>
Overrides <code>Papa.LocalChunkSize</code> and <code>Papa.RemoteChunkSize</code>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should explain what do both values instead of just saing that it overrides the behaviour.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't do that because I thought they were already explained at the end of the document. Do you want me to link them to https://www.papaparse.com/docs#configurable or should I explain them here again?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please, just add the link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 😄

pokoli
pokoli requested changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@pokoli pokoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for your PR, i've added ac omment on it. Could you please address it? I will be happy to merge it once fixed.

@akshaybabloo akshaybabloo requested a review from pokoli July 23, 2020 07:20
@pokoli pokoli merged commit 12bf28a into mholt:master Jul 23, 2020
@pokoli
Copy link
Collaborator

pokoli commented Jul 23, 2020

Merge it! Thank you so much!

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokoli pokoli Awaiting requested review from pokoli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add chunkSize to documentation
2 participants
@akshaybabloo @pokoli