Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chunkSize to documentation #673

Closed
EmperorArthur opened this issue Jun 6, 2019 · 1 comment · Fixed by #818
Closed

Add chunkSize to documentation #673

EmperorArthur opened this issue Jun 6, 2019 · 1 comment · Fixed by #818

Comments

@EmperorArthur
Copy link

EmperorArthur commented Jun 6, 2019

Hello, while attempting to use this library, I came across an issue.

Perhaps because of the way I was importing it, but I could not get LocalChunkSize, or RemoteChunkSize to work. (Bug #674)

const Papa = require("papaparse");
Papa.LocalChunkSize = 1024 * 1024;
Papa.parse(localBlob, {
  chunk: function(...){...}
});

Results in the entire file read in a single chunk.

However, after reading the code, this works:

const Papa = require("papaparse");
Papa.parse(localBlob, {
  chunkSize: 1024 * 1024,
  chunk: function(...){...}
});

This is not in the online documentation, and it really should be!

PS: Everything else is done by passing options, why does LocalChunkSize and RemoteChunkSize even exist?

@pokoli
Copy link
Collaborator

pokoli commented Jun 6, 2019

Thanks for reporting the issue.

Our documentation is on the docs folder of this repository. So it will be great if you can provide a PR documenting this issue.

pokoli pushed a commit that referenced this issue Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants