Abort Ruby Reaper when sidekiq queues are full #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francesmcmullin
force-pushed
the
perf/670-skip-reaping-if-queues-full
branch
from
ba5acc9 to
8b49160
Compare
francesmcmullin
force-pushed
the
perf/670-skip-reaping-if-queues-full
branch
from
3f43a10 to
963ac07
Compare
mhenrixon
reviewed
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve #670 .
This change is quite blunt - it silently returns from the ruby reaper if queues are longer than an arbitrary number (1,000 jobs). I'm conscious this may not be ideal for all use cases, but there are a lot of settings already. In my experience, the performance of the reaper degrades so much in these circumstances, it's not worth running, and it will occupy resources you could be using to clear that queue!
If there's anything I missed or further changes from a stylistic or architectural perspective that might help, just let me know and I'll be happy to work on this some more.