Refactor based on feedback from Reek/Code Climate

mhenrixon · Mar 13, 2022 · ba5acc9 · ba5acc9
1 parent cb531ac
commit ba5acc9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.reek.yml b/.reek.yml
@@ -111,6 +111,7 @@ detectors:
       - SidekiqUniqueJobs::OnConflict::Reject#push_to_deadset
       - SidekiqUniqueJobs::Orphans::RubyReaper#active?
       - SidekiqUniqueJobs::Orphans::RubyReaper#enqueued?
+      - SidekiqUniqueJobs::Orphans::RubyReaper#queues_very_full?
       - SidekiqUniqueJobs::UpgradeLocks#keys_for_digest
   RepeatedConditional:
     exclude:

diff --git a/lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb b/lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb
@@ -225,13 +225,16 @@ def queues_very_full?
         total_queue_size = 0
         Sidekiq.redis do |conn|
           queues(conn) do |queue|
-            queue_size = conn.llen("queue:#{queue}")
-            total_queue_size += queue_size
+            total_queue_size += conn.llen("queue:#{queue}")
 
-            return true if total_queue_size > MAX_QUEUE_LENGTH
+            return true if queue_size_larger_than_max(total_queue_size)
           end
         end
-        total_queue_size > MAX_QUEUE_LENGTH
+        queue_size_larger_than_max(total_queue_size)
+      end
+
+      def queue_size_larger_than_max?(queue_size)
+        queue_size > MAX_QUEUE_LENGTH
       end
 
       #