Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecation message to 'pipe-naming' rule #593

Merged
merged 1 commit into from
May 2, 2018
Merged

chore: add deprecation message to 'pipe-naming' rule #593

merged 1 commit into from
May 2, 2018

Conversation

rafaelss95
Copy link
Collaborator

Once someone try to use this deprecated rule, it'll show a warning like:

pipe-naming is deprecated. Message here


Not sure if it's the best message, but I've picked it in #519 (comment).

@rafaelss95
Copy link
Collaborator Author

rafaelss95 commented May 1, 2018

@mgechev @wKoza while I do understand why it's deprecated, I can still see useful things in it such as enforcing prefixes like we do for component and directive.

Can't we just deprecate the actual configuration?


A new configuration could be like this:

{
  "rules": {
    "pipe-naming": [true, "^ngx?[A-Z]+"]
    // or less generic, as an array
    "pipe-naming": [true, "ng", "ngx"]
  }
}

@mgechev mgechev merged commit 651be15 into mgechev:master May 2, 2018
@mgechev
Copy link
Owner

mgechev commented May 2, 2018

@rafaelss95 I like the regex config:

"pipe-naming": [true, "^ngx?[A-Z]+"]

It'll make more sense to rename the rule. If we have a rule with the same name but different semantics we'll create a lot of confusion.

@rafaelss95
Copy link
Collaborator Author

Does it makes sense to create another rule now? Or better wait for complete removal of this?

@rafaelss95 rafaelss95 deleted the chore-pipe-naming-rule branch May 2, 2018 04:39
@mgechev mgechev added this to the 4.4.0 - Ken Thompson milestone Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants