-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is the pipe-naming rule deprecated? #519
Comments
You can name your pipes only camel case if you try to use snake-case then your application will not compile. This is a compile-time error, not a linting one. The alternative is to use AoT. If there are a lot of people who want to keep this rule, we can. We haven't had issues with it recently and it doesn't cost us anything to not drop it. |
Thanks for your quick answer! Good to learn that there's a compile error now. I mainly wanted to know if the practices about prefixing pipes have changed. If it is not a good practice anymore then I guess the rule is not useful anymore. |
It's still considered a good practice. Prefixing will not be caught by the compiler thought. |
Great. Thank you! |
@mgechev is there a replacement for checking that the Pipe names are prefixed accordingly?
|
A couple of rules were deleted in pull request 2179, but they were actually just renamed and not depricated. Some details: mgechev/codelyzer#519 mgechev/codelyzer#791
A couple of rules were deleted in pull request 2179, but they were actually just renamed and not deprecated. Some details: mgechev/codelyzer#519 mgechev/codelyzer#791
Sorry for resurrecting this but I can still do: @Pipe({ name: 'underscore_name' })
export class UnderscoreNamePipe implements PipeTransform {} But according to the Angular style guide pipe name strings should use lowerCamelCase, ie. How can I enforce lowerCamelCase for pipe names? |
I'd recommend opening an issue in angular-eslint. Codelyzer is now deprecated. |
Hey!
Sorry to create an issue to ask such a question but I could not find any answer on the repo or in the doc.
I saw that the
pipe-naming
rule was deprecated in the Readme. Could you tell me what's the reason and if it was replaced with another rule?Thanks
The text was updated successfully, but these errors were encountered: