Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check block.Header.Type before cast #50

Closed
wants to merge 1 commit into from
Closed

check block.Header.Type before cast #50

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 31, 2021

Fixes #48.

@ghost
Copy link
Author

ghost commented Dec 31, 2021

Here's the output:

$ $OLDPWD/alen Autechre\ -\ SIGN/*.flac
E: Autechre - SIGN/SIGN-001-Autechre-M4 Lema.flac: flac.parseStreamInfo: incorrect type of first metadata block; expected stream info, got picture
$ _

@ghost ghost mentioned this pull request Dec 31, 2021
Closed
@mewmew
Copy link
Member

mewmew commented Dec 31, 2021

Thanks for submitting the PR @chucklebot!

re: #48 (comment)

Looks good to me! I didn't realize you'd made your PR when I got up this morning and so I just did a similar one (#50). Feel free to close it!

Many happy returns, hope you'll have a great 2022!

Closing this PR as it is a duplicate of #49.

Wish you a good start for 2022!

Cheers,
Henry & Robin

@mewmew mewmew closed this Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flac.parseStreamInfo reports wrong type when first block is not STREAMINFO
2 participants
@mewmew @vmpjdc