flac.parseStreamInfo reports wrong type when first block is not STREAMINFO

[ghost]

I happen to have some files where the first metadata block is not a STREAMINFO, but a PICTURE (this is totally bogus, of course).

The problem is reported as follows:

	si, ok := block.Body.(*meta.StreamInfo)
	if !ok {
		return block, fmt.Errorf("flac.parseStreamInfo: incorrect type of first metadata block; expected *meta.StreamInfo, got %T", si)
	}

However, thanks to the type assertion, si will always be a *meta.StreamInfo (albeit nil when !ok).

The error should probably report block.Header.Type instead.

[karlek]

Hi @chucklebot!

Nice catch, I made a PR with a fix. Would you be kind and test your "bogus" file and see if the problem persists?
#49

Happy new years, btw 🎆
Cheers
Henry & Robin

[ghost]

Looks good to me! I didn't realize you'd made your PR when I got up this morning and so I just did a similar one (#50). Feel free to close it!

Many happy returns, hope you'll have a great 2022!

[mewmew]

Fixed in #49.