Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flush after redirect with conntrack #1035

Merged
merged 15 commits into from
Feb 10, 2023

Conversation

meowjesty
Copy link
Member

@meowjesty meowjesty commented Feb 9, 2023

Adds conntrack --flush to the agent whenever stealer redirect rule is added.

The feature is gated behind the flush_connections: bool config, and the MIRRORD_AGENT_STEALER_FLUSH_CONNECTIONS agent env var.

@aviramha aviramha marked this pull request as draft February 9, 2023 06:08
@meowjesty
Copy link
Member Author

Added an env var for this feature, and you can enable it in mirrord-config with the flush_connections: true option.

Have tested it locally (not yet in k3s), and it doesn't seem to be breaking anything.

@meowjesty meowjesty requested a review from aviramha February 9, 2023 20:17
@meowjesty meowjesty marked this pull request as ready for review February 10, 2023 15:05
Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! We can merge it.

@meowjesty meowjesty enabled auto-merge February 10, 2023 15:11
@meowjesty meowjesty added this pull request to the merge queue Feb 10, 2023
Merged via the queue into metalbear-co:main with commit d57de25 Feb 10, 2023
@meowjesty meowjesty deleted the issue/1029/flush-steal branch February 10, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants